[FSSDK-11985] feat: add android logger support#90
Merged
muzahidul-opti merged 6 commits intomasterfrom Oct 29, 2025
Merged
Conversation
- Add FlutterLogbackAppender.java for logging events in the Flutter app - Integrate OptimizelyFlutterSdkPlugin with FlutterLogbackAppender - Update Constants.swift, SwiftOptimizelyFlutterSdkPlugin.swift, and related classes
- Adjust method to correctly convert log level strings to integers - Refactor switch statement for better readability and maintainability
- Remove unnecessary default log level value initialization - Refactor switch statement to directly return log levels for each case - Simplify comparison for warning log levels to include both "WARN" and "WARNING"
- Comment out configuration block in logback.xml - Modify log level 'WARNING' to 'WARN' in FlutterLogbackAppender.java
- Add check for kDebugMode to control printing of logs
muzahidul-opti
changed the title
jaeopt
requested changes
Oct 28, 2025
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good. I do not see customLogger injection for android side?
android/src/main/java/com/optimizely/optimizely_flutter_sdk/OptimizelyFlutterSdkPlugin.java
Show resolved
Hide resolved
android/src/main/java/com/optimizely/optimizely_flutter_sdk/OptimizelyFlutterSdkPlugin.java
Show resolved
Hide resolved
- Comment out old logback configuration - Add note explaining the use of FlutterLogbackAppender for logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlutterLogbackAppenderto intercept sdk's log and pass through flutter channel.Test plan
Issues